Implement solution#1802
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all core task requirements. The filtering functionality (name query, sex, centuries) and sorting (name, sex, born, died with three-click cycle: ascending → descending → disabled) are correctly implemented using URL Search Params. The CenturyFilter properly uses getAll for retrieval and append for adding multiple century values. Search parameters are correctly preserved when navigating within the People page via Navbar and PersonLink components. The sidebar with filters only appears when people are loaded. The noted issues (demo link not working and missing workflow file) are infrastructure/deployment concerns rather than code implementation problems—your actual implementation code is sound. All checklist requirements are satisfied. Congratulations on the solid implementation!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
dothearts
left a comment
dothearts
left a comment
There was a problem hiding this comment.
Demo Link not working (404 in console, white screen)
Please fix it and make the request.
Many thanks!
4 participants
[DEMO LINK] https://whomngmnt.github.io/react_people-table-advanced/
i have really problems with demo link(doesn't work).maybe you can check without it?